-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup-miniforge #76
Comments
The changes would be:
If that's the case, I guess it's easy to maintain with a little script, yes. I for one would prefer Miniforge to Miniconda as well. |
Another option would be to deprecate |
Hi @jaimergp So from your list:
Sure, but I think we can actually just remove the defult defaults (or update them) when users are not installing a new miniconda/miniforge since. I usually just used the bundled one (which tends to be faster even with updating conda).
Yep we can do that
Hmmm make sure the scripts replaces the right things on readmes and maybe just maintain a V1, V2 (major) versions so we do not need to recreate tags. |
I feel like not breaking back-compat is important, as we have seen. I'd say the v2 line needs to stay with a miniconda default, while v3 would be fine to change the defaults, if not the name. Either way, i'd say it's totally fine to just have prefixes, e.g. The work started on #98 pointed out that we need to beef up the "get me an installer" game, perhaps move it to another folder with a file per strategy, e.g.
as our architectures, etc. will become disjoint. To that end, we probably also want a higher-level, well-typed object of the parsed actions inputs so that we're not doing as many string things... the giant list of params is getting tiresome, and can only get worse. Part of me wants to chuck it all, and do the d.ts -> JSON schema thing, but we wouldn't get (useful) line numbers out, so some of the value would be reduced. |
After #126 lands, this could definitely move forward. The work would be:
|
Once nice thing: it's refreshingly simple to get the latest 30 releases of miniforge: https://api.github.com/repos/conda-forge/miniforge/releases without having to do URL scraping. Hooray! I think we'll also need another key, so e.g.:
Instead of |
Here's a WIP for the above (needs docs, etc): This starts to address some of the issues on using The speed difference looks negligible for our test cases, but it's probably still worth pursuing... and I dunno how we'll handle the missing functionality for |
PR up (with more tests and docs): #133 |
Hi @conda-incubator/setup-miniconda-team,
I created https://github.com/conda-incubator/setup-miniforge as a convenience for dealing directly with conda forge on defaults.
My plan was to have a script update the parts that needed updating so the it would follow this repo, and just have the script run every now and then to keep the things updated.
Maybe there is a better way of doing this.
Thoughts?
The text was updated successfully, but these errors were encountered: