Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Sunset the changelog #963

Closed
peytondmurray opened this issue Nov 7, 2024 · 4 comments
Closed

[ENH] - Sunset the changelog #963

peytondmurray opened this issue Nov 7, 2024 · 4 comments
Labels
needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠

Comments

@peytondmurray
Copy link
Contributor

Feature description

I'd like to sunset CHANGELOG.md:

  • To make it requires an extra step during the release process, which already requires a bunch of manual intervention
  • The process for making it requires using github-activity which doesn't see maintenance (although this is a fork, maybe we should use the upstream project?). It also doesn't allow you to use gh auth, so every time I make a release I need to mint a new PAT
  • The biggest reason to get rid of it is this is already something that the github web interface has a button for when releasing:

Image

@soapy1 @trallard @pavithraes thoughts?

Value and/or benefit

Fewer release steps, and less chance for human error when publishing the changelog.

Anything else?

No response

@peytondmurray peytondmurray added needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠 labels Nov 7, 2024
@soapy1
Copy link
Contributor

soapy1 commented Nov 7, 2024

+1 sounds good to me. I think the generated release notes are pretty sweet.

@trallard
Copy link
Collaborator

trallard commented Nov 11, 2024

The process for making it requires using github-activity which doesn't see maintenance (although this is a fork, maybe we should use the upstream project?). It also doesn't allow you to use gh auth, so every time I make a release I need to mint a new PAT

Not really. This is a suggestion, but nothing requires using such a tool (I intentionally added this as a footnote suggestion not to force folks to stick to a tool). The release captain can choose the best approach that suits them for this.

+1 sounds good to me. I think the generated release notes are pretty sweet.

I partially disagree here; while they are complete, the generated release notes clump everything together, making it harder for users to identify user-facing enhancements or deprecations.
The reason for having a changelog doc is to aim and follow https://keepachangelog.com/en/1.1.0/ or something similar that separates the types of changes included in a given release.
See for example the latest release notes https://github.com/conda-incubator/conda-store/releases/tag/2024.11.1 where it is not quite straightforward for an end-user to identify items that directly impact them.

So, if the team still wants to proceed and remove the changelog, I think an intentional effort should be made to make the auto-generated release notes easier for end-users to parse (of course, this will still need to be a release captain's responsibility during the release process, so it would continue to require some sort of manual work 🤷‍♀ ).
Or we could use something like https://scriv.readthedocs.io/en/1.5.1/index.html

@soapy1
Copy link
Contributor

soapy1 commented Dec 9, 2024

I think @trallard makes some really great points about the value of keeping the CHANGELOG.md. The changes introduced in #1006 will automatically generate the release notes (the releaser should update them to be a bit more human friendly). This should decrease the work going into keeping the changelog up to date for each release.

@peytondmurray I feel good about closing this issue if you do.

@peytondmurray
Copy link
Contributor Author

Let's do it! Closing now.

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in conda-store 🐍 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠
Projects
Archived in project
Development

No branches or pull requests

3 participants