Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Add package constraints to conda recipe #596

Closed
nkaretnikov opened this issue Sep 23, 2023 · 3 comments
Closed

MAINT - Add package constraints to conda recipe #596

nkaretnikov opened this issue Sep 23, 2023 · 3 comments

Comments

@nkaretnikov
Copy link
Contributor

Describe the bug

Add at least this constraint to the conda package: pydantic < 2.0.

For repro, see: #584. I don't know if the lower bound needs to be specified.

There are other constraints in conda-store/conda-store-server/environment.yaml, but I don't have a repro for those. So I suggest to just fix this for pydantic for now.

Expected behavior

pydantic 1.* is installed when you install conda-store-server.

How to Reproduce the problem?

See above.

Output

No response

Versions and dependencies used.

No response

Anything else?

No response

@nkaretnikov
Copy link
Contributor Author

Important: make sure the repro mentioned above no longer repros when constraints are added.

@jaimergp
Copy link
Member

This can be addressed with a patch via conda-forge/conda-forge-repodata-patches-feedstock.

@trallard trallard changed the title [BUG] - Add package constraints to conda recipe MAINT - Add package constraints to conda recipe Sep 25, 2023
@trallard trallard added type: maintenance 🛠 and removed type: bug 🐛 Something isn't working labels Sep 25, 2023
@trallard
Copy link
Collaborator

Already contained in the release issue, closing as addressed

@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in conda-store 🐍 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants