Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Only superadmin can login #593

Closed
kcpevey opened this issue Sep 21, 2023 · 2 comments · Fixed by nebari-dev/nebari#2028
Closed

[BUG] - Only superadmin can login #593

kcpevey opened this issue Sep 21, 2023 · 2 comments · Fixed by nebari-dev/nebari#2028
Labels
area: user experience 👩🏻‍💻 Items impacting the end-user experience type: bug 🐛 Something isn't working

Comments

@kcpevey
Copy link
Contributor

kcpevey commented Sep 21, 2023

Describe the bug

After upgrading to the 2023.9.1 release, only superadmin on nebari can log in to conda-store. Everyone else gets a Internal Sever Error when they click log in.

This will have an effect on #582 but this issue is describing a critical NEW behavior.

Expected behavior

I expect non-admins are able to log in.

How to Reproduce the problem?

  • Log into nebari using conda-store-ui 2023.9.1 as a user who is not in the superadmin group.
  • Attempt to log into conda-store
  • See Internal Server Error.

.

  • Log into nebari using conda-store-ui 2023.9.1 as a user who is in the superadmin group.
  • Attempt to log into conda-store
  • See success.

Output

No response

Versions and dependencies used.

No response

Anything else?

No response

@kcpevey kcpevey added type: bug 🐛 Something isn't working impact: high 🟥 This issue affects most of the conda-store users or is a critical issue area: user experience 👩🏻‍💻 Items impacting the end-user experience labels Sep 21, 2023
@kcpevey kcpevey transferred this issue from conda-incubator/conda-store-ui Sep 21, 2023
@trallard
Copy link
Collaborator

While trying to update the feedstock I bumped into a role_bindings error within the AuthenticationToken class in server, this should be looked into as this is more than likely impacting any authentication task

feedstock CI issue line: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=785272&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=904

@nkaretnikov
Copy link
Contributor

nkaretnikov commented Sep 23, 2023

I think the Internal Server Error is now fixed by nebari-dev/nebari#2028. Eskild and I tested this fix together yesterday. Later, Eskild also couldn't repro.

More context: the error is in nebari, not in conda-store. The reason it appeared after an update is because we're not careful about our public interfaces. nebari ships with a custom conda-store config (conda_store_config.py), which defines an auth class for Keycloak. In that class, there was code incompatible with the current conda-store version. This is due to recently made changes to conda-store, such as making get_conda_store an async function, but also how the db attr is accessed. We need to have a policy for public interfaces and don't break compatibility, and raise a clear error when we do.

@trallard trallard removed the impact: high 🟥 This issue affects most of the conda-store users or is a critical issue label Sep 25, 2023
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in conda-store 🐍 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience 👩🏻‍💻 Items impacting the end-user experience type: bug 🐛 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants