Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit logs frequently for debugging #435

Closed
costrouc opened this issue Mar 21, 2023 · 3 comments
Closed

Emit logs frequently for debugging #435

costrouc opened this issue Mar 21, 2023 · 3 comments
Labels
area: user experience 👩🏻‍💻 Items impacting the end-user experience needs: discussion 💬 This item needs team-level discussion before scoping type: enhancement 💅🏼

Comments

@costrouc
Copy link
Member

costrouc commented Mar 21, 2023

Instead of only emitting logs at the end of a job completing/finishing instead we should emit logs at a set frequency. This will require the build to potentially be an async process to be able to periodically update the logs on file/object storage.

@costrouc costrouc moved this to 🆕 New in Conda-Store Mar 29, 2023
@costrouc costrouc moved this from 🆕 New to 📋 Backlog in Conda-Store Apr 6, 2023
@costrouc
Copy link
Member Author

costrouc commented Apr 6, 2023

This is an example of how logs are uploaded https://github.com/Quansight/conda-store/blob/main/conda-store-server/conda_store_server/build.py#L24-L31.

Right now this is only done on success/failure of the build. Instead we would like to be able to successively update/upload the logs.

https://github.com/Quansight/conda-store/blob/main/conda-store-server/conda_store_server/build.py#L147-L159 should be continually uploading logs at a set frequency that is configurable on CondaStore.log_update_frequency = ... [s].

@costrouc
Copy link
Member Author

costrouc commented Apr 6, 2023

Redis would result long term in the best user experience.

  1. check that redis is enabled
  2. Potentially use redis streams https://redis.io/docs/data-types/streams-tutorial/ (but worth investigating if this is the right approach).

If a build is not completed/failed we can stream the logs via websockets, otherwise redirect the user to the storage for the logs (current behavior).

@leej3 leej3 moved this from 📋 Backlog to 🏗 In progress in Conda-Store May 8, 2023
@trallard trallard added needs: discussion 💬 This item needs team-level discussion before scoping area: user experience 👩🏻‍💻 Items impacting the end-user experience labels Jul 21, 2023
@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2023

Closing since frequent logs are currently emited. Please open another issue if more detailed logs are needed. It is hard to balance frequently writing logs and storing them on s3/object storage.

@costrouc costrouc closed this as completed Aug 8, 2023
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in conda-store 🐍 Aug 8, 2023
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in conda-store 🐍 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience 👩🏻‍💻 Items impacting the end-user experience needs: discussion 💬 This item needs team-level discussion before scoping type: enhancement 💅🏼
Projects
Archived in project
Development

No branches or pull requests

3 participants