Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set CMAKE vars #58

Merged
merged 2 commits into from
May 3, 2023
Merged

set CMAKE vars #58

merged 2 commits into from
May 3, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented May 3, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs2015_version' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs2015_runtime' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.

@isuruf isuruf added the automerge Merge the PR when CI passes label May 3, 2023
@github-actions github-actions bot merged commit cb71865 into conda-forge:main May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant