Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping tests on all platforms but windows is not valid #63

Closed
PhilipMay opened this issue Sep 20, 2018 · 5 comments
Closed

Skipping tests on all platforms but windows is not valid #63

PhilipMay opened this issue Sep 20, 2018 · 5 comments

Comments

@PhilipMay
Copy link
Member

Hi.
You skip all tests but on windows. This is not valid cause it breaks the build of every other package that depends on tensorflow on linux and mac.

# Skip the import test on Linux as wheel file require a more recent

@PhilipMay PhilipMay changed the title Skipping tests on all platforms but win is not valid Skipping tests on all platforms but windows is not valid Sep 20, 2018
@dhirschfeld
Copy link
Member

How does not running an import test "break the build"?

Edit: I see what you're getting at - not being able to import the tensorflow package on the CI servers breaks CI for all packages which need to import tensorflow.

It's not the skipping tests which is the problem but the fact that it doesn't actually work on the CI servers (which is why the tests were skipped). Given that, I'm inclined to close this issue as a dup of #6.

@PhilipMay
Copy link
Member Author

Ok...

@PhilipMay
Copy link
Member Author

So close it or not?

@dhirschfeld
Copy link
Member

I don't think it's valid anymore as TF is built from source so I'd close this issue. I can't myself as I'm no longer a maintainer.

@PhilipMay
Copy link
Member Author

Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants