Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cuda branch #134

Closed
izahn opened this issue Oct 4, 2021 · 5 comments
Closed

Create cuda branch #134

izahn opened this issue Oct 4, 2021 · 5 comments

Comments

@izahn
Copy link

izahn commented Oct 4, 2021

As discussed in #120 and #131 it has proven very difficult to produce cuda-enabled builds based on the master branch of this repository. I am therefore requesting the creation of a separate cuda (or gpu, etc., as you prefer) branch from which we can produce cuda-enabled builds. I have branches ready to PR at https://github.com/izahn/tensorflow-feedstock/tree/cuda_2.5.1 and https://github.com/izahn/tensorflow-feedstock/tree/cuda_2.6.0, I just need a suitable branch here PR to.

@izahn izahn mentioned this issue Oct 5, 2021
5 tasks
@isuruf
Copy link
Member

isuruf commented Oct 5, 2021

I don't think we are going to go with that branch given that it is not using the conda packages and vendor lots of packages.

@izahn
Copy link
Author

izahn commented Oct 5, 2021

OK, I'll just keep hosting them at https://anaconda.org/izahn I guess. Too bad, I think a lot of people would benefit from having a cuda enabled tensorflow on conda-forge.

@h-vetinari
Copy link
Member

I'm sorry that your work could not (yet!) be leveraged for conda-forge. There are efforts underway (not yet coalesced...) to get the CI beefed up enough to build this according to the CF-requirements, which would massively alleviate the current bottleneck of manual rebuilds (allowing more iteration on the recipe & by more contributors). It's a slog for everyone, and the trade-offs are not always crystal-clear, but I tend to agree with Isuru that it's better to do it right (even if it's slower).

I'm hoping someone can iterate on your PR + Isuru's suggestion. I might get around to it in a couple weeks.

@izahn
Copy link
Author

izahn commented Oct 5, 2021

Thanks @h-vetinari and @isuruf I totally get it, and thanks for all your efforts and leadership in the conda-forge community.

@izahn izahn mentioned this issue Oct 10, 2021
12 tasks
@hmaarrfk
Copy link
Contributor

I think that the work is close to being merged in.

Thanks for trailblazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants