Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Raysect #27726

Merged
merged 15 commits into from
Nov 21, 2024
Merged

Adding Raysect #27726

merged 15 commits into from
Nov 21, 2024

Conversation

munechika-koyo
Copy link
Contributor

@munechika-koyo munechika-koyo commented Sep 30, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@munechika-koyo munechika-koyo changed the title Raysect Adding Raysect Sep 30, 2024
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/raysect/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/raysect/recipe.yaml:

  • requirements: host: cython < 3.0 should not contain a space between relational operator and the version, i.e. cython <3.0
  • requirements: host: numpy < 2.0 should not contain a space between relational operator and the version, i.e. numpy <2.0
  • requirements: run: numpy < 2.0 should not contain a space between relational operator and the version, i.e. numpy <2.0
  • If python is a host requirement, it should be a run requirement.
  • This recipe is using a compiler, which now requires adding a build dependence on ${{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

Copy link

github-actions bot commented Sep 30, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/raysect/recipe.yaml) and found it was in an excellent condition.

Copy link

github-actions bot commented Sep 30, 2024

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/raysect/recipe.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: CnlPepper, mattngc. Please ask them to comment on this PR if they are.

recipes/raysect/recipe.yaml Outdated Show resolved Hide resolved
recipes/raysect/recipe.yaml Outdated Show resolved Hide resolved
recipes/raysect/recipe.yaml Outdated Show resolved Hide resolved
recipes/raysect/recipe.yaml Outdated Show resolved Hide resolved
Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@munechika-koyo
Copy link
Contributor Author

@conda-forge/staged-recipes this is ready to merge.

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@munechika-koyo
Copy link
Contributor Author

@conda-forge/help-python-c

@xhochy xhochy merged commit 8a42db5 into conda-forge:main Nov 21, 2024
7 checks passed
@munechika-koyo munechika-koyo deleted the raysect branch November 21, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants