Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at wagyu python port #13283

Merged
merged 7 commits into from
Nov 23, 2020
Merged

First pass at wagyu python port #13283

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6de8b96
First pass at wagyu recipe
bretttully Nov 20, 2020
e874f9a
Missing deps
bretttully Nov 20, 2020
ef3d4aa
Tests run locally
bretttully Nov 20, 2020
798bb48
Added reprit package
bretttully Nov 20, 2020
bd22546
Bumped version to include packaged license files
bretttully Nov 21, 2020
c68203a
Point reprit to read the docs
bretttully Nov 21, 2020
d42c134
PR feedback
bretttully Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions recipes/reprit/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
{% set name = "reprit" %}
{% set version = "0.3.1" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: 1e5198c852589518814118fa72dfd0b975e6633fed4c41ec22d69e1824b3b458

build:
number: 0
noarch: python
script: "{{ PYTHON }} -m pip install . -vv"

requirements:
host:
- python
- pip
run:
- python

test:
imports:
- {{ name }}
bretttully marked this conversation as resolved.
Show resolved Hide resolved

about:
home: https://github.com/lycantropos/{{ name }}
license: MIT
license_family: MIT
license_file: LICENSE
summary: 'Auto __repr__ method generation.'
description: 'Auto __repr__ method generation.'
doc_url: https://github.com/lycantropos/{{ name }}
bretttully marked this conversation as resolved.
Show resolved Hide resolved
dev_url: https://github.com/lycantropos/{{ name }}

extra:
recipe-maintainers:
- bretttully
- lycantropos
44 changes: 44 additions & 0 deletions recipes/wagyu/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{% set name = "wagyu" %}
{% set version = "0.2.2" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: d81019db773c33671db0b9422b5f2db6f8cb90d90eb6f44d81ec21aea4a6a76c

build:
number: 0
script: "{{ PYTHON }} -m pip install . -vv"

requirements:
build:
- {{ compiler('cxx') }}
host:
- python
- pip
- pybind11 >=2.6.1
bretttully marked this conversation as resolved.
Show resolved Hide resolved
run:
- python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream it looks like reprit >=0.3.0 is needed at runtime

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this package recipe to the PR as well... not sure if it needs to be a separate one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have multiple recipes in the same PR, but note the caveat in the final paragraph of https://conda-forge.org/docs/orga/guidelines.html#transferring-to-conda-forge. Basically staged-recipes will resolve their dependency and needed build order correctly, but there could be a race condition when they are transferred to the feedstocks where reprit may not be available on the CDN when wagyu is attempting to build and will fail requiring a manual restart of the CI to get it to work.

- reprit >=0.3.1

test:
imports:
- {{ name }}

about:
home: https://github.com/lycantropos/{{ name }}
license: MIT
license_family: MIT
license_file: LICENSE
summary: 'Python port of mapbox/wagyu library.'
description: 'Python port of mapbox/wagyu library.'
doc_url: https://github.com/lycantropos/{{ name }}
dev_url: https://github.com/lycantropos/{{ name }}

extra:
recipe-maintainers:
- bretttully
- lycantropos