-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at wagyu python port #13283
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@lycantropos please comment here if you are happy to be listed as a maintainer |
I don't mind and will be happy if it will help others to install and use this library. |
- pip | ||
- pybind11 | ||
run: | ||
- python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream it looks like reprit >=0.3.0
is needed at runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this package recipe to the PR as well... not sure if it needs to be a separate one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can have multiple recipes in the same PR, but note the caveat in the final paragraph of https://conda-forge.org/docs/orga/guidelines.html#transferring-to-conda-forge. Basically staged-recipes
will resolve their dependency and needed build order correctly, but there could be a race condition when they are transferred to the feedstocks where reprit
may not be available on the CDN when wagyu
is attempting to build and will fail requiring a manual restart of the CI to get it to work.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@synapticarbors what are the next steps for me to do here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested and then I'm happy to merge.
- pip | ||
- pybind11 | ||
run: | ||
- python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can have multiple recipes in the same PR, but note the caveat in the final paragraph of https://conda-forge.org/docs/orga/guidelines.html#transferring-to-conda-forge. Basically staged-recipes
will resolve their dependency and needed build order correctly, but there could be a race condition when they are transferred to the feedstocks where reprit
may not be available on the CDN when wagyu
is attempting to build and will fail requiring a manual restart of the CI to get it to work.
@synapticarbors: it looks like happened what you've predicted, CI failed, how can it be restarted? |
I just restarted it, but it's most likely going to fail again because |
Should be good now: |
Thanks for the help @synapticarbors and @lycantropos! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)