Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at wagyu python port #13283

Merged
merged 7 commits into from
Nov 23, 2020
Merged

Conversation

bretttully
Copy link
Contributor

@bretttully bretttully commented Nov 20, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
  • When in trouble be please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/wagyu) and found it was in an excellent condition.

@bretttully
Copy link
Contributor Author

@lycantropos please comment here if you are happy to be listed as a maintainer

@lycantropos
Copy link

I don't mind and will be happy if it will help others to install and use this library.

recipes/wagyu/meta.yaml Outdated Show resolved Hide resolved
recipes/wagyu/meta.yaml Outdated Show resolved Hide resolved
recipes/wagyu/meta.yaml Outdated Show resolved Hide resolved
- pip
- pybind11
run:
- python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream it looks like reprit >=0.3.0 is needed at runtime

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this package recipe to the PR as well... not sure if it needs to be a separate one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have multiple recipes in the same PR, but note the caveat in the final paragraph of https://conda-forge.org/docs/orga/guidelines.html#transferring-to-conda-forge. Basically staged-recipes will resolve their dependency and needed build order correctly, but there could be a race condition when they are transferred to the feedstocks where reprit may not be available on the CDN when wagyu is attempting to build and will fail requiring a manual restart of the CI to get it to work.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/reprit, recipes/wagyu) and found it was in an excellent condition.

@bretttully
Copy link
Contributor Author

@synapticarbors what are the next steps for me to do here?

Copy link
Member

@synapticarbors synapticarbors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested and then I'm happy to merge.

recipes/reprit/meta.yaml Outdated Show resolved Hide resolved
- pip
- pybind11
run:
- python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have multiple recipes in the same PR, but note the caveat in the final paragraph of https://conda-forge.org/docs/orga/guidelines.html#transferring-to-conda-forge. Basically staged-recipes will resolve their dependency and needed build order correctly, but there could be a race condition when they are transferred to the feedstocks where reprit may not be available on the CDN when wagyu is attempting to build and will fail requiring a manual restart of the CI to get it to work.

@synapticarbors synapticarbors merged commit 9941547 into conda-forge:master Nov 23, 2020
@lycantropos
Copy link

@synapticarbors: it looks like happened what you've predicted, CI failed, how can it be restarted?

@synapticarbors
Copy link
Member

I just restarted it, but it's most likely going to fail again because reprit isn't listed on the CDN yet (https://conda-static.anaconda.org/conda-forge/rss.xml -- warning 32 MB download). I'll try to keep an eye on this and when it's listed, I'll restart it again.

@synapticarbors
Copy link
Member

Should be good now:

https://anaconda.org/conda-forge/wagyu

@bretttully
Copy link
Contributor Author

Thanks for the help @synapticarbors and @lycantropos!

@bretttully bretttully deleted the wagyu branch November 23, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants