(test) add sp-repo-review as downstream

[MementoRC]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[henryiii]

There are a bunch of missing files for the test in source_files:. You have to add all files explicitly in conda.

[MementoRC]

Thanks for the quick reply. Are the failing tests simply skipping when sp-repo-review is not installed? Only 1 test failed without it
I'll follow-through tomorrow
Thanks

[henryiii]

Yep. If you want to add me as a maintainer, I can add the missing files, it’s just outside of the area I can comment on the pull request.

[henryiii]

What’s the one failure? Likely to also be a missing file. It assumes all files are present, and conda only copies files you list.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[MementoRC]

The failure was in test_self.py, that's why I deleted it, just to have a release out since conda-forge is not requiring this level of package verification typically. I f eventually understood how the tests worked. Now there are 2 fails that I don't understand.
(should it be ../src/repo-review somewhere?)

You are added as a maintainer. I don't know how familiar you are with conda-forge, the key requirement is to fork/local branch and not have other branches to this repo (typically in rare cases for example back-populating older version incompatible with the latest recipe)

[henryiii]

Hmm, interesting, I'm assuming the repo folder is named "repo-review". I'm guessing maybe I did that to make the path more interesting than "."? I think we can change that to either . or if we want something more interesting, tests/.. or .github/... We can skip that test for now with -k "not test_cmd_dual". The other failure is because src is missing, so the src check is returning None (skip).