Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream pytorch packages starting from 2.3.x require llvm-openmp<16, but this feedstock doesn't #249

Closed
1 task done
anjos opened this issue Aug 7, 2024 · 3 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@anjos
Copy link

anjos commented Aug 7, 2024

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

(I'm not sure this is relevant for this feedstock, but I thought I'd report it here for completeness.)

It seems the pinning of this package is outdated w.r.t. the upstream pytorch conda packages (from the pytorch channel). Starting from pytorch 2.3.x, upstream conda packages have the following (very restrictive) runtime pin:

- llvm-openmp <16  # [linux or arm64]

Reference: https://github.com/pytorch/builder/blob/main/conda/pytorch-nightly/meta.yaml#L49

The reason for this restriction seems to come from this (currently open) bug report: pytorch/pytorch#99625

The restrictive pinning imposed by the upstream pytorch packages creates a nasty issue making it impossible to install newer versions of scikit-learn alongside pytorch packages (c.f. pytorch/builder#1951, conda-forge/scikit-learn-feedstock#271).

The question is: is that pin relevant here? (i.e. is pytorch/pytorch#99625 reproducible with this feedstock?). If so, this package may be required to also use that pin. If not, then this is an indication that pin is possibly too restrictive and could potentially be relaxed from upstream.

Installed packages

N/A

Environment info

N/A
@anjos anjos added the bug Something isn't working label Aug 7, 2024
@anjos anjos changed the title Upstream pytorch packages starting from 2.3.x require llvm-openmp<16, but this package doesn't Upstream pytorch packages starting from 2.3.x require llvm-openmp<16, but this feedstock doesn't Aug 7, 2024
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Aug 7, 2024

I’m very sympathetic to these kinds of intergration issues but I’m having trouble following exactly what is happening.

To my knowledge the channel combinations that are supported are as follows

  • conda-forge and no other channnels
  • defaults + PyTorch

I say this because otherwise we aren’t really able to reliably recreate the problematic test scenario.

We typically allow more freedom in the OMP flavor installed. Do try to recreate. If you can I would be happy to help find the bug. But remember to only use one of the combinations listed above.

@anjos
Copy link
Author

anjos commented Aug 7, 2024

I guess we need first to check if pytorch/pytorch#99625 is reproducible with the current builds on platforms [linux or arm64], and for pytorch >=2.3. Is it that issue reproducible with this feedstock?

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Aug 7, 2024

I am not sure. Please report your results when you get them.

But from the scikit-learn feedstock page it seemed you were mixing channels in an unsupported way so I wanted to flag that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants