-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version madness #49
Comments
Here is one proposal. We simply update the repo to support only python 3 via pypi with the new version number. People can rely on older versions for python 2.7 and older eccodes builds. |
We can eventually mark the old versions as broken sometime near the end of next year or so. |
Certainly, for python 3 we could mark them as broken almost right away. |
😩
I'm OK with that but I'm not a heavy user of eccodes. @conda-forge/python-eccodes team, what do you think? |
Good question! The PyPI Package is Python3 only. So my suggestion would be to drop Python2 support for this feedstock now. As the new build would be for ecCodes v2.13.0 we might have to mark older py3 packages as broken then. Another thing is, that the new bindings can be compiled. @ocefpaf any idea how to incorporate this? |
This is not needed. Conda will resolve the version dependence of the individual build on ecCodes properly. |
Will |
It depends on what other packages are in the environment. if you never want the older package 2.12.3 installed, then marking the older ones as broken would do the trick as you say. However, this would have other consequences, like breaking support for users. |
Ah, I see, in #48 the package is just pulled from PyPI and installed alongside the eccodes build. But that means we will build eccodes twice. In the And, we would have a conda-forge version naming contradicting the |
I think I might have misinterpreted one of your comments. Indeed marking all python 3 builds of python-eccodes as broken and starting over is probably the best option. The question I thought I was answering was "Will conda get confused and try and install python-eccodes 0.9.2 with eccodes 2.12.3?" The answer to this question is no as long as the python-eccodes recipe depends on the eccodes one via the I think we can avoid a double build along with compiling the package, but that will take some effort to get working. |
IIUC, we can use the new version (0.9.2) in this feedstock and depend on eccodes 2.13.0 via |
That is basically right. However, we can keep the old builds with python 2 support around by not marking those as broken. We just can't easily support python 3 for both eccodes 2.12.3 and eccodes 2.13.0. |
So apparently the upstream package split out the python package (a good thing) but decided to reset the version number. So to update this feedstock for
eccodes >=2.13.0
, the new version would be 0.9.2. The current version of this feedstock is based on the upstreameccodes
version of2.12.*
.@conda-forge/python-eccodes How should we proceed here?
The text was updated successfully, but these errors were encountered: