Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: rerender #211

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

MNT: rerender #211

wants to merge 5 commits into from

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #210.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #210

@conda-forge-webservices conda-forge-webservices bot mentioned this pull request Jul 11, 2024
Open
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari marked this pull request as draft July 11, 2024 07:00
@h-vetinari
Copy link
Member

This is for determining the blast radius of an issue with meson 1.5.0; however, since pandas seems to be insisting on using meson 1.2.1 (in ways that I haven't been able to undo)

+ meson setup $SRC_DIR $TMP_DIR/build -Dbuildtype=release -Db_ndebug=if-release \
    -Db_vscrt=md --vsenv --prefix=$PREFIX -Dlibdir=lib --cross-file $BUILD_PREFIX/meson_cross_file.txt \
    --native-file=$TMP_DIR/build/meson-python-native-file.ini
  The Meson build system
  Version: 1.2.1    # <1.5

this is not immediately applicable.

@lithomas1
Copy link
Contributor

Maybe the host meson is what you're looking for here?
https://github.com/conda-forge/pandas-feedstock/blob/main/recipe/meta.yaml#L41

I've been meaning to bump the meson pin for a while (but forgot), but it looks like we dodged a bullet with meson 1.5 here because of it :).

@h-vetinari
Copy link
Member

Maybe the host meson is what you're looking for here?

Missed the forest for the trees 🙈

Thanks!

@h-vetinari
Copy link
Member

but it looks like we dodged a bullet with meson 1.5 here because of it :).

looks like pandas is not affected by the issue. :)

This was referenced Jul 16, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner

@WillAyd WillAyd Awaiting requested review from WillAyd WillAyd is a code owner

@datapythonista datapythonista Awaiting requested review from datapythonista datapythonista is a code owner

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche jorisvandenbossche is a code owner

@jreback jreback Awaiting requested review from jreback jreback is a code owner

@lithomas1 lithomas1 Awaiting requested review from lithomas1 lithomas1 is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@phofl phofl Awaiting requested review from phofl phofl is a code owner

@simonjayhawkins simonjayhawkins Awaiting requested review from simonjayhawkins simonjayhawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please rerender
3 participants
@conda-forge-admin @h-vetinari @lithomas1