Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OPENCV_SKIP_PYTHON_LOADER option to ensure that .pyi files are installed #434

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 4, 2024

Hopefully this will fix #374 without creating additional problems.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 4, 2024

do you want to add a test?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11183329111.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 4, 2024

I wonder if it is finally time to drop qt5 and ffmpeg6

@traversaro
Copy link
Contributor Author

do you want to add a test?

@Unturned3 @carschandler any idea for a reasonable test? I never used .pyi files, so I would just check the existence of the main .pyi in the root folder.

@traversaro
Copy link
Contributor Author

I wonder if it is finally time to drop qt5 and ffmpeg6

Yes, I wanted to first check if there was any regression of this hence the full build, if I start iterating on it I will disable the builds.

@carschandler
Copy link

I think the main goal is to have LSP recognize the types but I’m not sure a great way to test that programmatically, so I think just checking the existence of the pyi files is good enough!

Also, it seems like this is on the right track as this is the PR that was just merged in nixpkgs to fix the same issue.

NixOS/nixpkgs#317546

@hmaarrfk
Copy link
Contributor

Perhaps we can pull in the changes from #436 (if that PR works) into here and just merge.

Then get some feedback from users.

@traversaro
Copy link
Contributor Author

Perhaps we can pull in the changes from #436 (if that PR works) into here and just merge.

Then get some feedback from users.

I am away from office for work all week, I can try do it but if anyone wants to do it before me, feel free to do it!

@hmaarrfk
Copy link
Contributor

hmm i guess i closed the FFMPEG 6/7 dual builds. only ffmpeg7 now! whohooo!

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Oct 17, 2024
@traversaro
Copy link
Contributor Author

Thanks!

@github-actions github-actions bot merged commit 66939f2 into conda-forge:main Oct 17, 2024
39 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No .pyi files/type stubs?
4 participants