-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Build with flang 19 #119
base: main
Are you sure you want to change the base?
Conversation
…nda-forge-pinning 2024.07.15.16.56.22
Co-Authored-By: H. Vetinari <[email protected]>
In order to align with cf common practice
…nda-forge-pinning 2024.08.02.18.26.35
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.08.02.18.26.35
19fe65e
to
d2ca1b6
Compare
OK, I messed something up with the flang activation; I'll try again tomorrow with a fresh build (the build would pass if we set the flags manually, but I want to get to a point where that's not necessary). |
OK @Krande @traversaro, this now works as intended. It also works for flang 18, and curiously it doesn't even need There's also the fact that the environment then contains both |
@h-vetinari That's great news! What do you suppose is the remaining steps before we can update the global pinning feedstock for flang? I guess its this conda-forge/conda-forge-pinning-feedstock#1359 ? Btw @traversaro in connection with this #112 I have managed to build mumps against scotch and metis for windows here. It would require changes to scotch and metis. I started a draft PR for scotch in conda-forge/scotch-feedstock#82 where we agreed we'd wait for the conda-forge pinning feedstock. So once the conda-forge pinning is updated I'll start making the necessary PR's |
Gret work @h-vetinari and @Krande ! |
Yes, that's the right PR. I'm guessing building a couple key feedstocks and showing that flang 19 works on windows is going to go a long way in smoothing that path, so thanks for giving this a shot on a couple feedstocks already! I've successfully tested OpenBLAS & SciPy, but if you have more in mind then please go ahead and open PRs! :) The remaining steps then are: wait for flang 19 GA (September), release it, and then start the migration (which will certainly need a bit of shepherding..., not least because regro/cf-scripts#1655 hasn't been tested in the wild yet). |
Rebased #111 on top of #118, using the updated flang activation setup.