Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream patches #25

Open
traversaro opened this issue May 2, 2023 · 3 comments
Open

Upstream patches #25

traversaro opened this issue May 2, 2023 · 3 comments
Labels
question Further information is requested

Comments

@traversaro
Copy link
Contributor

Comment:

Currently the port has many local patches, some are probably necessary and are tricky to upstream as they are conda-forge-specific, but it would be great if we could upstream as much as possible, to reduce the effort necessary to forward port them when a new release comes out.

Existing PRs:
@traversaro traversaro added the question Further information is requested label May 2, 2023
@traversaro
Copy link
Contributor Author

traversaro commented Jun 19, 2023 •
edited
Loading

See google-deepmind/mujoco#937, that is upstreaming https://github.com/conda-forge/mujoco-feedstock/blob/main/recipe/cxx_devendor.patch .

@traversaro
Copy link
Contributor Author

See deepmind/mujoco#937, that is upstreaming https://github.com/conda-forge/mujoco-feedstock/blob/main/recipe/cxx_devendor.patch .

The last commit google-deepmind/mujoco@a599f68 should also remove the need for https://github.com/conda-forge/mujoco-feedstock/blob/c1521622f974f5923bbaca562ccdea2b6dfe0283/recipe/ccd_vec3_origin_link_problem.patch .

@traversaro
Copy link
Contributor Author

Related PR: google-deepmind/mujoco#937 .

This was referenced Jul 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@traversaro