Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgconfig file on Windows seems broken #14

Open
wolfv opened this issue Oct 31, 2021 · 2 comments
Open

pkgconfig file on Windows seems broken #14

wolfv opened this issue Oct 31, 2021 · 2 comments

Comments

@wolfv
Copy link
Member

wolfv commented Oct 31, 2021

We are currently patching the pkgconfig file for Windows. https://github.com/conda-forge/libode-feedstock/blob/master/recipe/modify-dotpc-win.patch We use a -I:{includedir} syntax that accidentally adds an extra : at the front of the path. These pkgconfig files are also read by e.g. CMake which is where this breaks (in OMPL).

I wonder if hte following patch would be better?

@traversaro maybe you know if this would work on Windows?

Index: ode-0.16/ode.pc.in
===================================================================
--- ode-0.16.orig/ode.pc.in
+++ ode-0.16/ode.pc.in
@@ -7,6 +7,6 @@ precision=@ODE_PRECISION@
 Name: ode
 Description: Open Dynamics Engine
 Version: @ODE_VERSION@
-Libs: -L${libdir} -lode
-Libs.private: -lstdc++ -lm
-Cflags: -I${includedir}
+Libs: -L${libdir} -lode_double
+# Libs.private: -lstdc++ -lm
+Cflags: -I${includedir}

cc @johnwason

@traversaro
Copy link
Contributor

If we ship a ode_double.lib library, this new version of the patch should work fine on Windows as well.

@wolfv
Copy link
Member Author

wolfv commented Nov 1, 2021

Yeah we do because of this condition in the WIN32 block:
https://bitbucket.org/odedevs/ode/src/5f371b978afa636b926e9b985de080279b380c5f/CMakeLists.txt#lines-530:534

Maybe I can use templating as well ... let me try! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants