Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the conda package for Jupytext 1.9.0 correct? #53

Closed
mwouts opened this issue Jan 5, 2021 · 9 comments
Closed

Is the conda package for Jupytext 1.9.0 correct? #53

mwouts opened this issue Jan 5, 2021 · 9 comments

Comments

@mwouts
Copy link
Contributor

mwouts commented Jan 5, 2021

There are two builds already for Jupytext 1.9.0, but I'm not so sure they are correct, because

  • the first one was created by a branch created on the jupytext-feedstock project (I saw too late that it should have been created on a fork)
  • and I can't install them, at least not with conda install jupytext==1.9.0 -c conda-forge, which ends with this error:
PackagesNotFoundError: The following packages are not available from current channels:

  - jupytext==1.9.0

@grst, would you mind to have a look at these builds? Do you see how we could fix them? Many thanks!

@martinRenou
Copy link
Member

It always takes a bit of time between merging PRs in the feedstock and actually having the package available on conda-forge. Maybe it's available now?

@martinRenou
Copy link
Member

martinRenou commented Jan 6, 2021

It is available now, but it looks like the labextension is not there. Looking at the logs it looks like the build failed silently: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=258738&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=542. I'll investigate.

@martinRenou
Copy link
Member

Looks like the labextension is not in the sdist. You'll need to make a patch release, I am pushing a PR fixing this.

@martinRenou
Copy link
Member

mwouts/jupytext#703

@martinRenou
Copy link
Member

It might be worth adding a test in the feedstock checking that the labextension is correctly installed, see https://github.com/conda-forge/ipycanvas-feedstock/blob/master/recipe/meta.yaml#L41

@mwouts
Copy link
Contributor Author

mwouts commented Jan 6, 2021

Yes, thank you @martinRenou . I'll see how to add this test.

Also I changed host to build in the meta.yaml, but maybe I shouldn't have, at least jupyterlab-feedstock also uses host:

https://github.com/conda-forge/jupyterlab-feedstock/blob/b4c7253b2ad0a0a96d700521912edea4b890280e/recipe/meta.yaml#L23-L31

@grst
Copy link
Member

grst commented Jan 6, 2021

afaik noarch packages should only have host. build is only for native compilation.
In practice, both should produce a working package.

Have you already figured out the remaining issues or do I still need to look at something?

@mwouts
Copy link
Contributor Author

mwouts commented Jan 6, 2021

afaik noarch packages should only have host. build is only for native compilation.

Thank you @grst ! I think it should be OK with the next version (and this morning I am able indeed to install jupytext=1.9.0 from conda-forge, maybe I did not left it enough time yesterday). I plan to make the following changes:

  • change build back to host
  • add a test in the feedstock to make sure that the labextension is installed, as suggested by @martinRenou above

@mwouts
Copy link
Contributor Author

mwouts commented Jan 6, 2021

I confirm that I was able to install jupytext=1.9.1 with

conda create -n test jupyterlab=3 jupytext -c conda-forge

and then, I could start Jupyter Lab 3.0 - and the Jupytext extension was working fine.

@mwouts mwouts closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants