-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to link grpc-cpp on Windows after abseil static build migration fails #214
Comments
We ran into a similar issue with zlib (non-private targets within grpc-cpp). This causes errors later when trying to look for abseil (or zlib) again. |
Will try adding the libabseil static into the host section as a stopgap, thanks |
Yeah, this affects all builds that are consuming grpc-cpp, which is why I'm trying to fix this ASAP in #215. I'm struggling to get the windows tests to run though, c.f. conda-forge/zstd-feedstock#64 & https://discourse.cmake.org/t/questions-about-find-package-cli-msvc/6194/6. |
I don't think the fix in #215 will suffice unfortunately, where if you're depending on another package that depends on a different version of abseil, say |
No, that shouldn't be possible. In any case, I've also sharpened the run-dep to pin the version from host, see d8b1195 |
Apologies, you are correct that the version is matching properly. That being said I'm still seeing similar issues with |
Still running into the same problems: https://dev.azure.com/conda-forge/84710dde-1620-425b-80d0-4cf5baca359d/_apis/build/builds/551996/logs/273 I believe the solver won't use the new builds since the abseil pinnings haven't been migrated quite yet: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/conda_build_config.yaml#L348-L350 So it looks like in the arrow-cpp grpc 1.46 builds the solver is grabbing Seems like these packages are broken and we should mark them as broken or put in a repodata patch to add a |
I'm fine with marking them as broken. That silent run-dependence is really unfortunate. Beyond that, I see two other (possibly complementary approaches):
|
@kkraus14 |
Solution to issue cannot be found in the documentation.
Issue
See logs from arrow-cpp build here: https://dev.azure.com/conda-forge/84710dde-1620-425b-80d0-4cf5baca359d/_apis/build/builds/551576/logs/480
It looks like it's trying to find abseil 20220623 symbols in the grpc lib and as far as I can tell those should be static linked into the grpc lib. The Arrow Flight shared library being built doesn't use abseil directly in any way or link to it via CMake.
I'm not sure exactly what's going on and this may not be a grpc issue, but figured I'd open an issue here to start.
cc @hmaarrfk @h-vetinari
Installed packages
Environment info
The text was updated successfully, but these errors were encountered: