Fix building SSE2 support for Windows #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanvolz
requested review from
alexbw,
egpbos,
grlee77,
jakirkham and
jschueller
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
egpbos
requested changes
Dec 1, 2022
With ENABLE_SSE2, the check for HAVE_SSE2 fails because the required compiler flag only exists for 32-bit builds. Since SSE2 is the default for 64-bit builds, we can set HAVE_SSE2 manually.
…nda-forge-pinning 2022.11.15.17.15.22
ryanvolz
force-pushed
the
sse2_windows
branch
from
4c698d3
to
729a83b
Compare
egpbos
approved these changes
Dec 1, 2022
|
Let's wait for CI to finish and then it's merging time. |
|
Thanks again! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)With
ENABLE_SSE2, the check forHAVE_SSE2fails because the required compiler flag (/arch:SSE2) only exists for 32-bit builds. Since SSE2 is the default for 64-bit builds, we can setHAVE_SSE2manually to build with SSE2 support.This probably fixes a reported issue with a package that uses
fftwwhere the program exits prematurely as soon as an FFT is needed. This seems to happen for users whose processors don't support AVX instructions and would fallback on SSE2, except it's not properly enabled. The caveat is that I've been unable to get the bug reporters to confirm whether this fixes the issue or not, but it still seems like a worthwhile fix regardless.