-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Check for glibc symbols in redist binaries #97
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12283031132. Examine the logs at this URL for more detail. |
Haha! It works! |
…nda-forge-pinning 2024.11.26.23.29.58
…nda-forge-pinning 2024.12.02.17.28.06
# NOTE: For binary redists os_version should match oldest supported glibc | ||
os_version: | ||
linux_64: alma8 | ||
linux_aarch64: alma8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that it's not necessary to set the os_version if we are checking the binaries for glibc symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna revert this until we get approval from conda-forge/core at a future meeting. Or maybe just wait until that meeting before merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussing this tomorrow at meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback from core meeting what that checking symbols explicitly is better than testing if loading crashes the library.
Thanks Daniel! 🙏 We also have some |
For clarity, if we were to add this test to cudnn it would not check if cudnn uses dlopen. It would only use dlopen to load cudnn? How is that better than link checking? |
@conda-forge-admin, please rerender |
…onda-forge-pinning 2024.12.11.09.08.10
This test already exists in this feedstock. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)In this PR, I have added a script developed by @mtjrider which checks for glib symbols in the shipped binaries.
In theory this means we don't have to match the glibc version with the os_version anymore,
but let's get explicit permission from the channel before doing that.Brought this up at conda-forge core meeting. Response was good.