-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip compiler activation (on Linux) #213
Skip compiler activation (on Linux) #213
Conversation
…nda-forge-pinning 2022.07.11.13.37.43
@conda-forge-admin, please lint |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please restart CI |
a596ecc
to
235bf25
Compare
@conda-forge-admin, please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/r-base-feedstock/actions/runs/2652484346. |
af16a0b
to
54b67ad
Compare
This should avoid some issues encountered when cross-compiling other downstream packages dependent on `r-base` that are doing their own cross-compilation.
54b67ad
to
7df8719
Compare
Windows failure is perplexing
|
Yes, i think that the windows opensl certificates had a bug. the m2 builds pull in a very old version of openssl where this isn't fixed. I had to work around using git for this reason in conda-forge/x264-feedstock#28 |
Any updates on this one? |
.ci_support/win_64_.yaml
Outdated
@@ -3,9 +3,9 @@ channel_sources: | |||
channel_targets: | |||
- conda-forge main | |||
libblas: | |||
- 3.8 *netlib | |||
- 3.9 *netlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham what do you think about reverting this file, and merging? This is really to help unix users move forward. We can deal with m2- stuff later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that will fix the Windows CI issue, happy to try. Didn't quite follow how this is connected though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wont. it will just keep this file consistent with the last windows build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess it isnt really important. i would merge :/ wile waiting for a fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. Yeah that makes sense.
Netlib 3.9 may be connected to the CI issues seen here on Windows. So revert to get CI working on Windows.
I think the reverted will not help the build pass. The actual fix, is removing the and listing things as dependencies |
|
I had to do something similar conda-forge/x264-feedstock#28 (Which I guess I'll merge when I have time to rerun crtical packages like ffmpeg in case of breakage) |
Gotcha. I don't feel confident enough to mess with that. So would rather leave that up to someone who knows what is going on there |
@conda-forge/core, any thoughts on next steps here? 🙂 |
@conda-forge/help-r |
It's a major issue that R has not been updated in months since the new version. Just allow this to go through minus windows if you can't fix windows |
@BEFH jakirkham and I are mostly trying to facilitate understanding of overarching issues that are specifics to conda-forge peculiarities. We don't always have the time to take an active role in maintaining every single repository. As I understand it, you would benefit from this repository getting up and running again. Help in doing this would be greatly appreciated. You should feel free forking from jakirkham's branch, and working toward addressing the curl incompatibilities with This help can help other maintainers more readily accept the PR (or the new one you open). |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like I wasn't able to push to the skip_comp_activation branch of jakirkham-feedstocks/r-base-feedstock. Did you check the "Allow edits from maintainers" box? NOTE: PRs from organization accounts cannot be rerendered because of GitHub permissions. This message was generated by GitHub actions workflow run https://github.com/conda-forge/r-base-feedstock/actions/runs/2802647228. |
@hmaarrfk, this is an absolutely astonishing reply. Anaconda and conda-forge are positioning anaconda as a development environment that can be used in the real world for a wide variety of coding and analytical tasks. Anaconda even has paid plans. To say "We don't always have the time to take an active role in maintaining every single repository." for a key repo that 10s of thousands of other packages rely on is also bizarre, and the thumbs-down is just petty. To let a major, key part sit out of date for over 2 months and 2 minor versions, when the only blocker is windows is an absolutely bizarre decision. Telling users "why don't you just fix it?" is even worse. I don't develop on Windows. I have no experience with Windows build toolchains. I don't have time to learn right now. But there are alternatives for both Python and R environments. Poor maintenance and snide comments are the kind of things that drive away users who actually want to get work done. This isn't some small hobby project by aone or two devs; it's a key part of a large ecosystem with a commercial product. If you need more assistance, ask for it from Anaconda or from other conda-forge devs. Get your act together or Anaconda is going to become an also-ran. |
@BEFH hmaarrfk isn't paid by Anaconda (as far as I know) and conda-forge isn't his responsibility any more than it is yours. His comment that he can't take an active role in maintaining every single repository is perfectly reasonable. Welcome to the world of community-driven open source software! I personally agree that the thumbs-down with no comment or elaboration wasn't very nice -- but it wasn't hmaarrfk who did that!
On the contrary, this is the only way. Conda-forge will only continue to exist as long as there is a pipeline of users becoming contributors.
I feel you. Building for so many platforms and architectures is a major pain, and often puts contributors in the position of being asked to work on stuff that they don't care about and will never use. Personally I would love to abandon Windows in conda-forge entirely, but that will probably never happen.
Many open-source projects have some commercial component, but the commercial and community components are often separate as they are in the case of Anaconda and conda-forge. There is some cooperation, but Anaconda hasn't committed itself to maintaining conda-forge as far as I know.
This is pretty unreasonable. Why do you think any of this is hmaarrfk's responsibility? |
I think @BEFH just wanted an updated |
@izahn, I never originally called out @hmaarrfk. All I did was suggest that a release was done without windows support until the windows release could be fixed.
@hmaarrfk responded with a snide missive that basically read like "if you don't like the pace of development, fix it yourself." That's why I responded how I did. I never expected either of you to quickly fix windows because there were clearly upstream issues. I don't think it's unreasonable to prioritize fast releases on a key package that 10s of thousands of others rely on, and I don't think @hmaarrfk's response was reasonable. He could have ignored my post if he was too busy, or said that it was a priority but was taking longer than expected, or said it wasn't possible to temporarily disable one platform, or any number of responses. If I've misread the post, I apologize. If it sounds like I'm specifically going after you or @hmaarrfk for the package being delayed, I apologize. But I don't think my OP was unreasonable, and I don't think it's unreasonable in general to expect some sort of urgency for packages like |
As you mentioned, @izahn, there was just an updated release that worked by disabling certificate checking for Windows, and I do appreciate that. |
Honestly, I dont really know what to say. You asked what the holdup was. I gave a clear reason for my (in)action, and clear reasons why I interacted on specific topics ( It seems that the feedstock maintainers are OK skipping windows. I think that their choice to make, not mine (even as a core member). I'm glad that got you going again. |
@hmaarrfk, as I said, my impatience was not with you specifically. I appreciate the work you do and was not specifically asking YOU to hurry up. For a project this big, though, it shouldn't be down to individual maintainers to just decide they have time to fix major, key parts of the project. There should be some level of prioritization, and Anaconda should be dedicating paid devs to fix major stuff like this. It's a key part of their business model for the software to continue to be useful. |
Anaconda isn't that involved in conda-forge though, they have their own |
Hi. I am here to remind us all to follow the NumFocus code of conduct (https://numfocus.org/code-of-conduct):
Please keep the discussion above civil and be respectful of the time and effort people volunteer for free to maintain conda-forge. If this thread escalates further, we will have to take more intrusive moderation actions. |
On a different note, @jakirkham can you either rebase your PR on the current master or merge it into your branch? I'd like to merge this in but can't update your fork to clean up the merge conflict :) |
@conda-forge-admin, please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/r-base-feedstock/actions/runs/2820705290. |
Thanks @dpryan79! 🙏 Have updated the PR to address merge conflicts. Please let me know if anything else is needed 🙂 |
@jakirkham Much appreciated! |
Great thanks Devon! 🙏 |
Submitted PRs to apply the same change to
Note these are the current |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes conda-forge/ctng-compiler-activation-feedstock#74
For packages that depend on
r-base
and also compile packages of their own, the inclusion and activation of compilers pulled in byr-base
can conflict with those needed by the recipe as part of the package build. Particularly this comes up when the packaging being built is cross-compiled. To this end, this PR switches the compilers installed byr-base
to ones that are not activated.cc @isuruf @hcho3