Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild with libcxx>=17 #62

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Rebuild with libcxx>=17 #62

merged 14 commits into from
Aug 26, 2024

Conversation

saraedum
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@saraedum saraedum requested a review from isuruf as a code owner August 22, 2024 12:39
@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@saraedum saraedum added the automerge Merge the PR when CI passes label Aug 22, 2024
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Aug 22, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@saraedum
Copy link
Member Author

@wlav is cppyy-cling going to work with clang 16 with root 63202 patches?

I am running in more problems because we have updated the libcxx in macOS and I guess that using a more recent clang colud help.

@saraedum
Copy link
Member Author

So, essentially this conda-forge/conda-forge-pinning-feedstock#4890 now breaks a lot of builds for me that depend on cppyy. On macOS, I am now forced to use libcxx>=17 but cppyy-cling forces libcxx<17 through the clangdev 13 package we are building against.

I think I'll have to disable macOS for the downstream packages of cppyy since it seems to be not usable here at the moment.

Any thoughts @isuruf?

@saraedum saraedum changed the title Rebuild with latest libcxx Rebuild with latest libcxx>=17 Aug 22, 2024
@saraedum saraedum changed the title Rebuild with latest libcxx>=17 Rebuild with libcxx>=17 Aug 22, 2024
saraedum added a commit to saraedum/clangdev-feedstock that referenced this pull request Aug 23, 2024
since
conda-forge/conda-forge-pinning-feedstock@408e182
forces a more modern libcxx on macOS, pinning here to libcxx breaks
downstream packages such as cppyy, see conda-forge/cppyy-cling-feedstock#62 (comment)

As indicated in
conda-forge#300 (comment)
there should be no problem using libcxx 17 here as well.
recipe/meta.yaml Outdated Show resolved Hide resolved
cppyy refuses to build with clang 16 at the moment.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package cppyy-cling using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cppyy-cling-feedstock/actions/runs/10527513648.

@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender.

unclear which combinations are going to work out.
@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender.

conda-forge-webservices[bot] and others added 2 commits August 26, 2024 12:06
@saraedum
Copy link
Member Author

@conda-forge-admin, please rerender.

@wlav
Copy link

wlav commented Aug 26, 2024

@wlav is cppyy-cling going to work with clang 16 with root 63202 patches?

I am running in more problems because we have updated the libcxx in macOS and I guess that using a more recent clang colud help.

Upstream is at llvm16 (released), but is also very close to a release build on llvm18, so I was waiting on the latter. However, given these troubles, I'll start moving to llvm16 now.

TGenCollectionStreamer.cxx:879:18: error: integer value 4097 is outside the valid range of values [0, 63] for the enumeration type 'EProperty'
@saraedum
Copy link
Member Author

I managed to build this on macOS, I am not sure whether this is functional but maybe I am lucky.

@saraedum saraedum merged commit b0dab76 into conda-forge:main Aug 26, 2024
26 checks passed
@wlav
Copy link

wlav commented Sep 26, 2024

I pushed the changed needed for LLVM16 into https://github.com/wlav/cppyy-backend/ . Still six failing tests on Linux. Haven't tried the other platforms yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants