ENH: Add example of conda_build_config.yaml python_min map #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewfeickert
force-pushed
the
feat/note-on-min-python
branch
from
59fe707
to
1ebca2a
Compare
matthewfeickert
commented
Nov 12, 2024
docs/maintainer/knowledge_base.md
Outdated
Comment on lines
1525
to
1529
| :::tip[Hint] | ||
|
|
||
| Adding an explicit `python_min` to your `noarch: python` recipe can be an effective way to ensure the required | ||
| Python in your package's metadata is enforced at `conda-build` time, as the build will fail if the package's | ||
| required Python version is different from `python_min`. |
There was a problem hiding this comment.
If it isn't clear from this that I'm trying to explain a situation where the existing feedstock would have
python_min:
- "3.8"and the new package metadata (e.g. from PyPI) has
[project]
...
requires-python = ">=3.9"resulting in a build failure (which is good as the python_min is now out of date) let me know and I can revise this.
4 tasks
* Add example of the map that is required for python_min to be manually enforced if it exists in recipe/conda_build_config.yaml. * Add a tip that adding an explicit python_min also ensures that python_min used by conda-build does not deviate from the required Python metadata in the Python package. If the Python package required Python metadata is updated and the feedstock's recipe is not the build will fail, signalling that there is a metadata mismatch that needs to be corrected.
matthewfeickert
force-pushed
the
feat/note-on-min-python
branch
from
1ebca2a
to
7a56541
Compare
matthewfeickert
commented
Nov 12, 2024
|
|
||
| Adding an explicit `python_min` to your `noarch: python` recipe can be an effective way to ensure the required | ||
| Python in your package's metadata is enforced at `conda-build` time, as the build will fail if the package's | ||
| required Python version is newer than `python_min`. |
There was a problem hiding this comment.
I previously had this as "different from" but that's wrong. It only acts as a guard if the required Python metadata in the package advances to a newer Python than python_min.
13 tasks
|
thank you! |
|
Thank you both! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recipe/conda_build_config.yaml.python_minalso ensures thatpython_minused byconda-builddoes not deviate from the required Python metadata in the Python package. If the Python package required Python metadata is updated and the feedstock's recipe is not the build will fail, signalling that there is a metadata mismatch that needs to be corrected.PR Checklist:
docs/orcommunity/, you have added it to the sidebar in the corresponding_sidebar.jsonfileRelevant section of the netlify docs preview: https://deploy-preview-2370--conda-forge-previews.netlify.app/docs/maintainer/knowledge_base/#noarch-python