-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot cancel the build while waiting for a lock #70
Comments
It feels like this trap isn't working https://github.com/concourse/pool-resource/blob/master/assets/common.sh#L12 I don't see why it wouldn't and I can't replicate it locally. |
I've setup a pipeline using a lock pool with username & password (github Personal Access Token) and the behaviour changes slightly. While the job is waiting for the lock you still can't abort the job, it continues waiting, however once it claims the lock (assuming it eventually can) the job does then terminate as interrupted The expected processes are running:
If I try to cancel the job through the UI again the bash script exits (PID 7 above) but the go command is still running
If in the hijacked session I kill the go process then the task correctly exits ( |
Sorry this shouldn't have closed, I merged a PR into a fork |
Describe the bug
When trying to claim a lock which is already claimed, and therefore waiting for the lock to be released, the task does not respond correctly to cancel requests, such as a job timeout, or a cancel in the UI of concourse, or issuing a cancel via the cli.
The only way I find I can terminate the job is to hijack the container and kill a running
ssh-agent
process in the container.Reproduction steps
I think very likely related
Expected behavior
Additional context
No response
The text was updated successfully, but these errors were encountered: