Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No helpful error output when private key provided requires password #16

Open
ghost opened this issue Jun 13, 2016 · 2 comments
Open

No helpful error output when private key provided requires password #16

ghost opened this issue Jun 13, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Jun 13, 2016

To reproduce this issue, set the pipeline below and provide an SSH key that has a password in the private_key field. It's pretty quick to set up a new lock repo and add the generated public key as a deploy key on the repo (make sure to grant it write access). Then run the acquire-lock job. It errors out with absolutely no output. Obviously this wouldn't work since there's no way to provide a password -- I just discovered it when I pasted in the wrong key by mistake -- but we can hopefully save someone else the trouble by grepping their key for ENCRYPTED or something like that and printing an appropriate warning.

---
jobs:
- name: acquire-lock
  public: true
  plan:
  - put: test-pool
    params: {acquire: true}

- name: release-lock
  public: true
  plan:
  - put: test-pool
    params: {acquire: test-pool}

resources:
- name: test-pool
  type: pool
  source:
    uri: [email protected]:<REDACTED>/test-pool-resource.git
    branch: master
    pool: test-pool
    private_key: <private key that requires a password>
@ghost ghost changed the title No helpful output when private key provided requires password No helpful error output when private key provided requires password Jun 13, 2016
@concourse-bot
Copy link
Collaborator

concourse-bot commented Jun 13, 2016

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • #121434747 No helpful error output when private key provided requires password

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

@jtarchie
Copy link

We should provide equivalent error messaging as the git resource.

@vito vito removed the enhancement label Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants