Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Option to not push to registry on out #249

Closed
akshaymankar opened this issue Nov 29, 2018 · 3 comments
Closed

Proposal: Option to not push to registry on out #249

akshaymankar opened this issue Nov 29, 2018 · 3 comments

Comments

@akshaymankar
Copy link

Currently the resource always pushes to a registry on out, but we have a usecase where we don't really want to push the image anywhere, but package it in a bosh release. So, I would like to propose a flag called push_to_registry which will default to true, but can be toggled off.

/cc @vlad-stoian

@hephex
Copy link
Contributor

hephex commented Dec 15, 2018

I was looking into implementing this feature because I'm facing a similar problem, but out is supposed to create a new version of the resource and docker image resources are versioned using their digest string which is not available until the image gets pushed to the registry (see distribution/distribution#1662).

@akshaymankar any idea how to overcome this "limit"?

@jonahgeorge
Copy link

Has anyone come up with a temporary solution for this?

@vito
Copy link
Member

vito commented Mar 10, 2019

There's not really any way to avoid pushing to the registry, since this resource is fundamentally about representing external state (as all resources are). The new pattern going forward is to use the builder task instead for image building and then the registry-image resource for image pushing.

These aren't quite official yet, since I'd like to wrap up concourse/rfcs#7 before 'blessing' the builder task, but we're using them in production and it's going pretty well.

Gonna close this issue out though since there won't be any changes made to the docker-image resource to support this, especially as we'll be deprecating it in favor of builder and registry-image. Thanks all!

@vito vito closed this as completed Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants