Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concourse Helm Chart - Windows support for custom Worker deployments #344

Open
jgifford25 opened this issue Sep 25, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@jgifford25
Copy link

Is your feature request related to a problem? Please describe.

Bash files don't run well on Windows based containers!

Describe the solution you'd like

Would like an option in the helm chart values configuration to disable/disconnect the pre-stop-hook.sh setup in the worker-prestop-configmap.yaml, worker-deployment.yaml, worker-statefulset.yaml so that I can deploy a custom built Windows container for worker operations using the helm chart without worrying how a Windows container is going to handle the execution request of a bash script.

This could be enabled with a general flag setting in the values.yaml file specifying the container type, i.e. Windows or Unix with a default of Unix. Depending on the flag value, that bash script lines would be enabled or disabled.

Implementation of this functionality might allow the inclusion in the future of a custom Powershell script that executes the same functionality as the the Bash script.

Describe alternatives you've considered

No response

Additional context

No response

@jgifford25 jgifford25 added the enhancement New feature or request label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant