From ab11b26b879a5ced483aa62218636ad0b2c8c68f Mon Sep 17 00:00:00 2001 From: Teale Fristoe Date: Tue, 22 Oct 2024 20:07:05 -0700 Subject: [PATCH] Final PR review feedback. --- v3/src/components/web-view/web-view-constants.ts | 1 - v3/src/components/web-view/web-view-defs.ts | 1 + v3/src/components/web-view/web-view.tsx | 2 +- v3/src/data-interactive/handlers/attribute-handler.ts | 2 +- v3/src/hooks/use-drag-drop.ts | 1 - 5 files changed, 3 insertions(+), 4 deletions(-) delete mode 100644 v3/src/components/web-view/web-view-constants.ts diff --git a/v3/src/components/web-view/web-view-constants.ts b/v3/src/components/web-view/web-view-constants.ts deleted file mode 100644 index 0611e5d9a1..0000000000 --- a/v3/src/components/web-view/web-view-constants.ts +++ /dev/null @@ -1 +0,0 @@ -export const kWebViewBodyClass = "codap-web-view-body" diff --git a/v3/src/components/web-view/web-view-defs.ts b/v3/src/components/web-view/web-view-defs.ts index b826adb1c7..7f47b99c10 100644 --- a/v3/src/components/web-view/web-view-defs.ts +++ b/v3/src/components/web-view/web-view-defs.ts @@ -3,3 +3,4 @@ export const kV2GameType = "game" export const kV2GuideViewType = "guideView" export const kV2WebViewType = "webView" export const kWebViewTileClass = "codap-web-view" +export const kWebViewBodyClass = "codap-web-view-body" diff --git a/v3/src/components/web-view/web-view.tsx b/v3/src/components/web-view/web-view.tsx index 2c965e3df0..a9678829a6 100644 --- a/v3/src/components/web-view/web-view.tsx +++ b/v3/src/components/web-view/web-view.tsx @@ -3,7 +3,7 @@ import React, { useRef } from "react" import { t } from "../../utilities/translation/translate" import { ITileBaseProps } from "../tiles/tile-base-props" import { useDataInteractiveController } from "./use-data-interactive-controller" -import { kWebViewBodyClass } from "./web-view-constants" +import { kWebViewBodyClass } from "./web-view-defs" import { WebViewDropOverlay } from "./web-view-drop-overlay" import { isWebViewModel } from "./web-view-model" diff --git a/v3/src/data-interactive/handlers/attribute-handler.ts b/v3/src/data-interactive/handlers/attribute-handler.ts index 3148da8807..c2b87f5f70 100644 --- a/v3/src/data-interactive/handlers/attribute-handler.ts +++ b/v3/src/data-interactive/handlers/attribute-handler.ts @@ -1,6 +1,6 @@ import { kContainerClass } from "../../components/container/container-constants" import { kPluginAttributeDragId } from "../../components/drag-drop/drag-drop-constants" -import { kWebViewBodyClass } from "../../components/web-view/web-view-constants" +import { kWebViewBodyClass } from "../../components/web-view/web-view-defs" import { appState } from "../../models/app-state" import { IAttribute } from "../../models/data/attribute" import { createAttributesNotification, updateAttributesNotification } from "../../models/data/data-set-notifications" diff --git a/v3/src/hooks/use-drag-drop.ts b/v3/src/hooks/use-drag-drop.ts index a4b20ad763..760c387ed7 100644 --- a/v3/src/hooks/use-drag-drop.ts +++ b/v3/src/hooks/use-drag-drop.ts @@ -2,7 +2,6 @@ import { Active, DataRef, DragEndEvent, Modifier, useDndMonitor, useDraggable, UseDraggableArguments, useDroppable, UseDroppableArguments } from "@dnd-kit/core" -import { kIndexColumnKey } from "../components/case-tile-common/case-tile-types" import { kTitleBarHeight } from "../components/constants" import { IDataSet } from "../models/data/data-set" import { useInstanceIdContext } from "./use-instance-id-context"