Ensure msvc cppstd compatibility fallback does not ignore 194 binaries #16573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Yes, I think the combinatorics is not complete, and the empty element of each factor should also be used for the combinations. |
|
Good catch. I've changed the fix to address what I think the underlying issue is, can discuss it later :) |
memsharded
approved these changes
Jul 1, 2024
memsharded
approved these changes
Jul 1, 2024
czoido
approved these changes
Jul 1, 2024
AbrilRBS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Ensure msvc cppstd compatibility fallback does not ignore 194 binaries.
Docs: Omit
This is one of the alternatives, another one might be to test each factor in isolation too?
Closes #16564