[AutotoolsToolchain] Honoring tools.android:ndk_path conf
#16502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jun 19, 2024
| if not self._is_cross_building or not self._conanfile.settings.get_safe("os") == "Android": | ||
| return ret | ||
| ndk_path = self._conanfile.conf.get("tools.android:ndk_path", check_type=str) | ||
| if ndk_path: |
There was a problem hiding this comment.
What if ndk_path is not defined? Isn't it mandatory in other places?
There was a problem hiding this comment.
It's true that if it's not defined, in other toolchains like Meson or CMake, it is raised as an exception, but do we want to do that here? It'd be a breaking change because people have always included all the needed flags via buildenv.
czoido
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Honoring
tools.android:ndk_pathconf. Setting the needed flags to cross-build for Android.Docs: conan-io/docs#3787
Closes: #13443