Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android ndk_version #16494

Merged
merged 3 commits into from
Jun 25, 2024
Merged

android ndk_version #16494

merged 3 commits into from
Jun 25, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 18, 2024 •
edited by czoido
Loading

Changelog: Feature: Add os.ndk_version for Android.
Docs: conan-io/docs#3783

Close #16453

I am still not super convinced about the approach, or if we should use closed versions

@memsharded memsharded added this to the 2.5.0 milestone Jun 18, 2024
AbrilRBS
AbrilRBS approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with waiting to see if we get reports of users finding issues before adding checks for the scheme of the new subsetting 👍

@czoido czoido merged commit 0ee3da7 into conan-io:develop2 Jun 25, 2024
2 checks passed
@memsharded memsharded deleted the feature/android_ndk_version branch June 26, 2024 17:37
@AbrilRBS AbrilRBS mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

[question] How to guarantee that a specific Android NDK is used for resolving packages
3 participants
@memsharded @czoido @AbrilRBS