fix PkgConfigDeps in build context #15763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :param build_context_suffix: `dict` with all the suffixes | ||
| :return: `str` with the suffix | ||
| """ | ||
| if not build_context_suffix or not req.is_build_context: | ||
| if not build_context_suffix or not req.build: |
There was a problem hiding this comment.
Good catch 👏
It has to be solved for BazelDeps too.
franramirez688
approved these changes
Feb 27, 2024
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Mar 3, 2024
fix PkgConfigDeps
czoido
pushed a commit
that referenced
this pull request
Mar 13, 2024
* wip * wip * wip * wip * wip * wip * package_id config_mode * test * wip * trying auto * wip * fix conan_server timestamp truncation * fix test * wip * wip * lockfiles * Update conan/cli/commands/config.py Co-authored-by: Francisco Ramírez <[email protected]> * Update conans/client/graph/graph_binaries.py Co-authored-by: Francisco Ramírez <[email protected]> * Update conans/test/functional/command/config_install_test.py Co-authored-by: Francisco Ramírez <[email protected]> * Fix `conan profile show --format=json` for profiles with scoped confs (#15747) Fix conan profile show --format=json for profiles with scopd confs * review * fix issues and improve CMakeToolchain.preprocessor (#15756) * fix issues and improve CMakeToolchain.preprocessor * fix test * list --profile argument (#15697) * list --profile argument * filtering * fix PkgConfigDeps in build context (#15763) fix PkgConfigDeps * [CMakeToolchain]Adding visibility flag to CONAN_C_FLAGS (#15762) Adding visibility flags to C flags too * PkgConfigDeps refactor (#15771) * allow self.name/self.version for build_folder_vars (#15705) * wip * wip * wip * wip --------- Co-authored-by: Francisco Ramírez <[email protected]> Co-authored-by: Rubén Rincón Blanco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix
PkgConfigDepsgenerating .pc files for itstool_requireswhen it is in the build context already.Docs: Omit
Close #14920
I have already tried to backport this to Conan 1.X, but it seems it is not possible, because the graph model there does not support the correct processing of
tool_requireswhen already in the build context.