Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE_SYSTEM_VERSION is not correctly set when autodetected #16282

Closed
czoido opened this issue May 16, 2024 · 0 comments · Fixed by #16335
Closed

CMAKE_SYSTEM_VERSION is not correctly set when autodetected #16282

czoido opened this issue May 16, 2024 · 0 comments · Fixed by #16335
Assignees
Milestone

Comments

@czoido
Copy link
Contributor

czoido commented May 16, 2024

As stated in the CMake documentation when in Apple systems CMAKE_SYSTEM_VERSION is the version for the Darwin version, but we are setting the sdk version, which does not seem correct.
In general the best approach for cross-building would be to set these variables via the conf or user toolchain, but we may fix this by converting from the OS version to the Darwin version.

_system_version = self._conanfile.settings.get_safe("os.sdk_version")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants