Modernize rtmidi for conan v2 #9644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
And CMake names? Also I see no difference in conanfile between 4.x.x & all folders, they should be merged to avoid extra maintenance. |
This comment has been minimized.
This comment has been minimized.
SpaceIm
reviewed
Mar 7, 2022
ghost
mentioned this pull request
Co-authored-by: SpaceIm <[email protected]>
This comment has been minimized.
This comment has been minimized.
SpaceIm
reviewed
Mar 7, 2022
| ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} | ||
| - PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}) | ||
| + PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/rtmidi) |
There was a problem hiding this comment.
This patch is useless, include convention in CMake config file for 5.0.0 is broken: thestk/rtmidi#285
You should set includedirs in package_info() to os.path.join("include", "rtmidi") for 5.0.0 (or patch install destination of headers in 5.0.0), and update test package accordingly.
There was a problem hiding this comment.
Done here: 31a493f
There was a problem hiding this comment.
ok, you just have to update include in test package now
This comment has been minimized.
This comment has been minimized.
SpaceIm
reviewed
Mar 7, 2022
Co-authored-by: SpaceIm <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SpaceIm
approved these changes
Mar 8, 2022
ericLemanissier
approved these changes
Mar 8, 2022
SSE4
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.