Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: ignore MSB warnings #3109

Closed
wants to merge 2 commits into from
Closed

cmake: ignore MSB warnings #3109

wants to merge 2 commits into from

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Oct 5, 2020 •
edited
Loading

Specify library name and version: cmake/all

I will push the patch upstream but want to test it first on CI.

update:

@Croydon
Copy link
Contributor

Croydon commented Oct 5, 2020 •
edited
Loading

This will fail

The offending CMake is NOT the one we are building but rather the one we are using to build it (we build CMake with CMake)

Hence, you would need to patch the installed CMake on the Windows CI machines

@madebr
Copy link
Contributor Author

madebr commented Oct 5, 2020

The sources contain:

# Make sure we can find internal find_package modules only used for
# building CMake and not for shipping externally
list(INSERT CMAKE_MODULE_PATH 0 ${CMake_SOURCE_DIR}/Source/Modules)

So there is hope 🤞

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cmake/3.16.2' failed in build 1 (a18d8617fef8db46ad8e54d7502bbf83dcd450ba):

@madebr madebr closed this Oct 6, 2020
@madebr madebr reopened this Oct 6, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 3 (b92be03e162f811a072b05a3c27ef36e3017ad48)! 😊

@madebr
Copy link
Contributor Author

madebr commented Oct 7, 2020

@Croydon
The patch is working!
The MSVC logs still contain the MSB warning so c3i's props file was not patched yet.

@Croydon
Copy link
Contributor

Croydon commented Oct 7, 2020

Wohoo. Nevermind, don't listen to me. You are doing amazing work 🎉 🥳 🎉

So, we are going to merge this and push it upstream? 🤔

This was referenced Oct 7, 2020
Closed
Merged
@a4z
Copy link
Contributor

a4z commented Oct 7, 2020

just out of interest, what is the actually problem solved here ?
is this patching cmake to satisfy conan hooks?

@Croydon
Copy link
Contributor

Croydon commented Oct 7, 2020

No, there was a change in the Windows CI which causes MSVC to produce a warning which is treated by CMake effectively as an error

See here #3053 (comment)

@Croydon Croydon mentioned this pull request Oct 7, 2020
Closed
a4z
a4z approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@a4z a4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, not sure if an approval from me helps to merge that faster, but for the case it helps, here it is :-)

jgsogo
jgsogo suggested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will fix it in the infra, no need to make the recipe more complex just because we are not doing things right in the backend.

@danimtb , what about releasing a new version of C3i? I think it is ready.

@Croydon
Copy link
Contributor

Croydon commented Oct 7, 2020 •
edited
Loading

@jgsogo Upstream already agreed to welcome a PR fixing this, so I don't see a reason why we shouldn't patch existing versions on CCI.

The patch is rather small and can be dropped for future versions as soon as it is upstreamed

https://gitlab.kitware.com/cmake/cmake/-/issues/21270

@danimtb
Copy link
Member

danimtb commented Oct 7, 2020

@jgsogo done #3138

@jgsogo
Copy link
Contributor

jgsogo commented Oct 8, 2020

I prefer not to add complexity (maintenance, ifs,...) to the recipe if it is not needed. This is a PR we'd never have done if the CI hadn't failed. After #3138 this is no longer a problem.

@madebr
Copy link
Contributor Author

madebr commented Oct 8, 2020

This patch just got merged at https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5348

@Croydon
Copy link
Contributor

Croydon commented Oct 8, 2020

Thank you for pushing this forward @madebr

I prefer not to add complexity (maintenance, ifs,...) to the recipe if it is not needed. This is a PR we'd never have done if the CI hadn't failed. After #3138 this is no longer a problem.

It is an upstream problem and may also affect other environments similar to C3I, but since it is now upstreamed, it at least won't be a problem for future CMake versions. So I guess it is fine with me if we don't patch the older versions.

That said, we got a new "unexpected error" here: 🙈
#2941 (comment)

@conan-center-bot
Copy link
Collaborator

All green in build 4 (b92be03e162f811a072b05a3c27ef36e3017ad48)! 😊

@madebr
Copy link
Contributor Author

madebr commented Oct 8, 2020

I'll close it. I see the other pr will apply the openssl version bump.

@madebr madebr closed this Oct 8, 2020
@madebr madebr mentioned this pull request Oct 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo requested changes

@a4z a4z a4z approved these changes

@Croydon Croydon Croydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@madebr @Croydon @conan-center-bot @a4z @danimtb @jgsogo