Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add 3.17.3 + 3.17.2 + 3.16.7 #1761

Merged
merged 6 commits into from
May 29, 2020
Merged

Conversation

Croydon
Copy link
Contributor

@Croydon Croydon commented May 27, 2020

Specify library name and version: cmake/3.17.3 and cmake/3.17.2 and cmake/3.16.7

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

config.yml syntax error in build 1:

Could not detect the recipe for version 3.16.2 at /home/conan/workspace/onan-center-pull-request_PR-1761/recipes/cmake/all|

@Croydon Croydon force-pushed the cmake-move-to-3 branch from cf2ef6b to 0ad4fd3 Compare May 27, 2020 23:12
@conan-center-bot
Copy link
Collaborator

config.yml syntax error in build 2:

Could not detect the recipe for version 3.16.2 at /home/conan/workspace/onan-center-pull-request_PR-1761/recipes/cmake/all|

@conan-center-bot
Copy link
Collaborator

All green in build 3 (c270a7f4fce01264475e03e0803a2ac028f35863)! 😊

@madebr
Copy link
Contributor

madebr commented May 28, 2020

Would this be a good opportunity to replace os_build and arch_build with os and arch?
Also, this recipe should include build_type, because the CI builds a debug cmake package on Windows MSVC.

I think this would fix #1705

See https://c3i.jfrog.io/c3i/misc/logs/pr/1761/3/cmake/3.16.2/456f15897172eef340fcbac8a70811f2beb26a93/

profile:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug
compiler=Visual Studio
compiler.runtime=MTd
compiler.version=14
os=Windows
os_build=Windows
[options]

[env]

[build_requires]

@Croydon Croydon changed the title cmake: add 3.17.2 + 3.16.7 cmake: add 3.17.3 + 3.17.2 + 3.16.7 May 28, 2020
@Croydon
Copy link
Contributor Author

Croydon commented May 28, 2020

Would this be a good opportunity to replace os_build and arch_build with os and arch?
Also, this recipe should include build_type, because the CI builds a debug cmake package on Windows MSVC.

Sounds good to me

@Croydon
Copy link
Contributor Author

Croydon commented May 28, 2020

Is the build pipeline stuck?

@conan-center-bot
Copy link
Collaborator

All green in build 5 (7a35663056e60dc1b0f95deb1478d768e8af5059)! 😊

@uilianries uilianries requested review from danimtb, jgsogo and SSE4 May 29, 2020 13:03
@SSE4 SSE4 merged commit 2cc6385 into conan-io:master May 29, 2020
@SSE4 SSE4 deleted the cmake-move-to-3 branch May 29, 2020 14:37
@madebr
Copy link
Contributor

madebr commented May 29, 2020

I don't think adding build_type has fixed #1705.
Because the compiler.runtime for Visual Studio can still be MTd.
See https://c3i.jfrog.io/c3i/misc/logs/pr/1761/5/cmake/3.17.3/01edd76db8e16db9b38c3cca44ec466a9444c388/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants