Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept str and torch.device in device handling; add unittests #246

Closed
constantinpape opened this issue Oct 25, 2023 · 1 comment
Closed

Accept str and torch.device in device handling; add unittests #246

constantinpape opened this issue Oct 25, 2023 · 1 comment
Assignees
@constantinpape

Comments

@constantinpape
Copy link
Contributor

Eventually we should add a few more unit-tests for the device handling and update the type annotations so that both strs and torch devices are allowed. I will take care of this later.

Originally posted by @constantinpape in #245 (review)
@constantinpape constantinpape self-assigned this Oct 25, 2023
@GenevieveBuckley GenevieveBuckley mentioned this issue Nov 3, 2023
Merged
@constantinpape
Copy link
Contributor Author

This has been implemented in #251 and #280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@constantinpape constantinpape

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@constantinpape