You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The github actions CI runs very slowly on the master branch because of the test_training.py file. We would like to improve the speed, and/or skip the unreasonably slow tests on github actions.
On the dev branch, without test_training.py the CI job finishes in about 6 minutes. But on the master branch including the test_training.py file, it takes over half an hour.
Additionally, I often saw the CI job killed with an error. The error did not describe why the job failed.
I don't think it was a timeout, by default github actions has a 6 hour timeout, and the lowest timeout I set was 1 hour.
Maybe the CI machine ran out of memory? This seems possible, and is something to check.
Update: I think it's the test/test_training.py file that was making the CI so slow.
Yes, unfortunately test_training.py is quite slow.
A possible workaround would be to mark the super slow tests as pytest.mark.slow and skip them in the CI jobs.
Yes, that's one possibility. Before that I want to check if I can improve this test a bit to speed it up on CI and so that we can just run it with the normal tests.
(I developed the test on my notebook, and it was fast enough, but I guess the CPU in the CI is weaker, so that it takes quite long.)
...
I will then:
look into speeding up test_training.py (or mark it as pytest.mark.slow if I can't speed it up without making the test worse)
The text was updated successfully, but these errors were encountered:
I have stripped down test_training in #233 now. It still works as expected and everything runs much faster now (ca. 5 minutes for all tests and ca. 8 minutes for the complete CI).
The github actions CI runs very slowly on the master branch because of the
test_training.py
file. We would like to improve the speed, and/or skip the unreasonably slow tests on github actions.On the
dev
branch, withouttest_training.py
the CI job finishes in about 6 minutes. But on themaster
branch including thetest_training.py
file, it takes over half an hour.Additionally, I often saw the CI job killed with an error. The error did not describe why the job failed.
Comment from PR 223
The text was updated successfully, but these errors were encountered: