Add to Gift Aid batch gives error

[michael-chaplin-gmcvo]

Using 3.0.2 plus patch for version number (https://github.com/compucorp/uk.co.compucorp.civicrm.giftaid/pull/68/files)
and PHP 7.1.

ParseError: syntax error, unexpected 'new' (T_NEW) in CRM_Civigiftaid_Form_Task_AddToBatch->preProcess() (line 99 of /home/gmcvodataba/public_html/sites/default/files/civicrm/extensions/uk.co.compucorp.civicrm.giftaid-civi4.5/CRM/Civigiftaid/Utils/Contribution.php).

Also get this error when trying to run a Gift Aid Submission Report.

[davejenx]

Looks like it needs '=& new' changed to '= new' at CRM/Civigiftaid/Utils/Contribution.php line 99 plus other occurrences in that file.
http://php.net/manual/en/migration70.incompatible.php

[davejenx]

Created PR: #74 .

[michael-chaplin-gmcvo]

I did start down that road but there were numerous instances of the '=&' problem and once I'd fixed those, there were issues in other files too.

[davejenx]

@mikantchap Could you apply #74 then report here the further error messages you get?

[michael-chaplin-gmcvo]

Is that patch wrong? Its adding the & back in on 99?

//$batchContribution =& new CRM_Core_DAO_EntityBatch( );
$batchContribution =& new CRM_Batch_DAO_EntityBatch();

[davejenx]

@mikantchap No, it's removing the '&'.
https://patch-diff.githubusercontent.com/raw/compucorp/uk.co.compucorp.civicrm.giftaid/pull/74.patch

[michael-chaplin-gmcvo]

Sorry yes. Here's the next error:

ArgumentCountError: Too few arguments to function CRM_Utils_Hook::invoke(), 7 passed in /home/gmcvodataba/public_html/sites/default/files/civicrm/extensions/uk.co.compucorp.civicrm.giftaid-civi4.5/CRM/Civigiftaid/Utils/Hook.php on line 118 and exactly 8 expected in CRM_Utils_Hook->invoke() (line 154 of /home/gmcvodataba/public_html/sites/all/modules/civicrm/CRM/Utils/Hook.php).

[davejenx]

@mikantchap That's the error you reported at #72 , which I believe is not specific to PHP 7. @vinuvarshith indicated that another PR, #68 fixes issues #71 & #72 .

[michael-chaplin-gmcvo]

Hey thanks...looks like its fixed!

[davejenx]

@mikantchap Could you clarify, from your last two comments, what is now fixed and what is still broken, after applying patches #68 and #74, when you do the following operations:

• Add to Gift Aid batch (this issue)
• On submitting a test/live payment from a contribution page (issue Error with CiviCRM 5.10.3 #72): best to update that issue so people can understand the status of the issue.

[michael-chaplin-gmcvo]

After applying patches #68 and #74, I am able to Add to Gift Aid batch.

[michael-chaplin-gmcvo]

Hi Can you say when the fix will go in a release?