Don't try to parse aliases versions which doesn't contain exact version

composer · Jan 6, 2020 · e443591 · e443591
1 parent 2667cf1
commit e443591
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 vendor/
 .php_cs.cache
 composer.lock
+.idea
diff --git a/src/VersionParser.php b/src/VersionParser.php
@@ -106,6 +106,11 @@ public function normalize($version, $fullVersion = null)
             $fullVersion = $version;
         }
 
+	    if (preg_match('{^(\^[^,\s]++) ++as ++([^,\s\^]++)$}', $version, $match) ||
+	        preg_match('{^([^,\s]++) ++as ++(\^[^,\s\^]++)$}', $version, $match)) {
+		    throw new \UnexpectedValueException('the alias must be an exact version');
+	    }
+
         // strip off aliasing
         if (preg_match('{^([^,\s]++) ++as ++([^,\s]++)$}', $version, $match)) {
             $version = $match[1];

diff --git a/tests/VersionParserTest.php b/tests/VersionParserTest.php
@@ -123,6 +123,8 @@ public function failingNormalizedVersions()
             'non-dev arbitrary' => array('feature-foo'),
             'metadata w/ space' => array('1.0.0+foo bar'),
             'maven style release' => array('1.0.1-SNAPSHOT'),
+            'Not exact version on alias on first part' => array('^1.0.0+foo as 2.0'),
+            'Not exact version on alias on second part' => array('1.0.0+foo as 2.0'),
         );
     }