Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate ways of shrinking the filesize #8

Open
matthewmueller opened this issue Jan 3, 2014 · 8 comments
Open

investigate ways of shrinking the filesize #8

matthewmueller opened this issue Jan 3, 2014 · 8 comments

Comments

@matthewmueller
Copy link
Member

Right now it's 15.20kb. Not too bad, but a lot of the functions are only used once.

Also, we might not need to support everything that jQuery 2.x supports or maybe not need to handle obscure bugs that people don't usually run into.

@eivindfjeldstad
Copy link

what browsers are you targeting? I would love to help out with this:D I've been thinking of doing something similar for a while, but haven't gotten around to it. CSS has been the only reason I sometimes find myself missing jQuery.

@matthewmueller
Copy link
Member Author

@eivindfjeldstad that'd be great. For the product we've been building, were supporting IE9+ and for every other browser, the most current and 1 previous version.

@tj
Copy link
Member

tj commented Jan 25, 2014

hrrrm yea dom itself was less than 15 i think haha, i forget now

@tj
Copy link
Member

tj commented Jan 25, 2014

nvm 28, not sure where it's at now

@matthewmueller
Copy link
Member Author

Tempted to replace this implementation with ianstormtaylor/css. I feel like I made a mistake porting jQuery.css to this library. Rather than fix ALL THE BUGS we can start small and build back up as we need to.

This change may have downstream effects on component/dom users.

Thoughts @Owners?

@jonathanong
Copy link
Contributor

+1 i love rewrites

@mattdesl
Copy link

mattdesl commented Dec 7, 2014

If a rewrite is planned, one or both of these may prove useful.

https://www.npmjs.org/package/dom-css
https://www.npmjs.org/package/prefix-style

@matthewmueller
Copy link
Member Author

cool, we should probably just be using dom-css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants