You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to specify a directory where I keep MS2PIP models, rather than the default ~/.ms2pip. This is currently impossible when using MS2PIPFeatureGenerator. ms2pip.correlate() accepts model_dir argument, but MS2PIPFeatureGenerator has no code to pass it through. So, ms2pip.correlate() gets model_dir=None and defaults to ~/.ms2pip internally.
I'd like to specify a directory where I keep MS2PIP models, rather than the default ~/.ms2pip. This is currently impossible when using MS2PIPFeatureGenerator. ms2pip.correlate() accepts model_dir argument, but MS2PIPFeatureGenerator has no code to pass it through. So, ms2pip.correlate() gets model_dir=None and defaults to ~/.ms2pip internally.
Proposal is to add it as constructor argument:
Set it as attribute:
Then in add_features(), pass it to correlate():
The text was updated successfully, but these errors were encountered: