Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge commits don't work #84

Closed
tobias-feil-plana opened this issue Jan 10, 2024 · 4 comments
Closed

Merge commits don't work #84

tobias-feil-plana opened this issue Jan 10, 2024 · 4 comments
Labels
duplicate This issue or pull request already exists question Further information is requested wontfix This will not be worked on

Comments

@tobias-feil-plana
Copy link

Hello, is there a way to enable merge commits? Mine start with "Merge branch 'master'..."

@thekaveman thekaveman added duplicate This issue or pull request already exists question Further information is requested wontfix This will not be worked on labels Jan 10, 2024
@thekaveman
Copy link
Member

Hello @tobias-feil-plana -- thank you for the question.

The TLDR; is that support for merge commits is not entirely clear even in the Conventional Commits spec itself, and we try to stay as close to that spec as possible here. Luckily there are a number of workarounds and alternate tools that may fit your use-cases better than this tool.

Please see prior threads where we have discussed this, e.g. #39, #76.

@thekaveman thekaveman closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
@tobias-feil-plana
Copy link
Author

Hello, thanks for the answer and the links! Sounds good, I'll try to do it that way 👍

@Viibrant
Copy link

Hello @tobias-feil-plana -- thank you for the question.

The TLDR; is that support for merge commits is not entirely clear even in the Conventional Commits spec itself, and we try to stay as close to that spec as possible here. Luckily there are a number of workarounds and alternate tools that may fit your use-cases better than this tool.

Please see prior threads where we have discussed this, e.g. #39, #76.

Would it be possible to provide a default? Either a new merge type or default ot allowing them?

@thekaveman
Copy link
Member

Hi @Viibrant

Would it be possible to provide a default?

The default is already provided by git, e.g. you can invoke the default behavior on a per-commit basis by using the --no-verify flag.

As we've discussed in these issues, this tool will remain focused on checking for Conventional Commits formatting, something that git does not do by default.

@compilerla compilerla locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants