Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify static_hostname configuration #1672

Closed
ballPointPenguin opened this issue Apr 9, 2023 · 0 comments · Fixed by #1745
Closed

Simplify static_hostname configuration #1672

ballPointPenguin opened this issue Apr 9, 2023 · 0 comments · Fixed by #1745
Labels
🧹 chore 🧩 config .env and other configuration concerns

Comments

@ballPointPenguin
Copy link
Contributor

Problem:
The buildStaticHostname function is needlessly convoluted and really we should probably just have the static hostname be the value of the STATIC_FILES_HOST and not do any of this guesswork.

Suggested solution:
Simple use STATIC_FILES_HOST and scrap the buildStaticHostname logic.

Alternative suggestions:
Double check that there are no significant use cases for additional logic (tests, preprod, custom URLs, etc)
@ballPointPenguin ballPointPenguin added feature-request For new feature suggestions 🧹 chore 🧩 config .env and other configuration concerns and removed feature-request For new feature suggestions labels Apr 9, 2023
@metasoarous metasoarous mentioned this issue Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧹 chore 🧩 config .env and other configuration concerns
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove buildStaticHostname server logic compdemocracy/polis
1 participant
@ballPointPenguin