Importing in Next.js project and scoping CSS #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @compassion-gds/[email protected] - @compassion-gds/[email protected]
A comment on GH suggested this workaround until Storybook 7 is officially supported by Percy percy/percy-storybook#715 (comment)
kidroca
force-pushed
the
kidroca/fix-importing-in-nextjs-project
branch
from
4b0e690 to
552c56c
Compare
kidroca
force-pushed
the
kidroca/fix-importing-in-nextjs-project
branch
5 times, most recently
from
71532c2 to
554ed98
Compare
kidroca
force-pushed
the
kidroca/fix-importing-in-nextjs-project
branch
from
554ed98 to
86a0e3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Next requires CSS imported from node_modules to only be css modules to avoid possible collisions
gds/react package was updated so it does not rely on gds/css as peer dependency
Token generation scripts are extracted out of package.json and updated slightly for more coverage
Some css file changes to facilitate CSS modules
Tested the package versioning script and changelog generation