Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in is_any_outdated() #55

Closed
bachdavi opened this issue Apr 7, 2019 · 2 comments
Closed

Infinite loop in is_any_outdated() #55

bachdavi opened this issue Apr 7, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@bachdavi
Copy link
Collaborator

bachdavi commented Apr 7, 2019

is_any_outdated() uses an internal timer which advance_domain() changes.
If we probe a Dataflow that has not started or has no current inputs we might run into an infinite loop in the server at : worker.step_while(|| server.is_any_outdated());
because we already advanced the inputs but the probe still only sees the "old" timestamps.

@comnik comnik added the bug Something isn't working label Apr 7, 2019
@comnik
Copy link
Owner

comnik commented Apr 28, 2019

This should also be addressed by f09ec28, again, tests required.

@comnik
Copy link
Owner

comnik commented Apr 29, 2019

Impossible to have an infinite loop, because we step fixed amounts now :)

@comnik comnik closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants