BUG: Fix DICOM display fields merging #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If rules defined different display values for the same field, then the last one was used only. This is now fixed - Fix typo in default rule
cpinter
force-pushed
the
dicom-database-display-tables-4
branch
from
cffd0cd
to
0d74510
Compare
|
@jcfr I noticed a problem with merging the fields, and although it does not cause an actual bug in this version, it will when more plugins start popping up. It's good I caught it now. Also fixed a typo that would have caused issues with the same thing. |
jcfr
approved these changes
Apr 16, 2019
|
It would be good, I agree. I'll do it when I have some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.